Fix position of inline help icon caused by changes in #1350#1400
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1400 +/- ##
========================================
Coverage 86.48% 86.48%
========================================
Files 340 340
Lines 85818 85818
Branches 4815 4815
========================================
Hits 74218 74218
Misses 11577 11577
Partials 23 23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zorkow
approved these changes
Dec 15, 2025
Member
zorkow
left a comment
There was a problem hiding this comment.
From what I can see (sample expression
Looks better!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression in the positioning of the help icon for in-line math expression caused by the changes in #1350. The positioning in that commit cause in-line help icons to not be attached to the in-line expression, but to the nearest block-level parent.
The fix is to use the old CSS for inline math and move the new CSS to the
[display="true"]selector.